[VPlan] Treat VPVector(End)PointerRecipe as single-scalar, if ops are. #169249
Conversation
VPVector(End)PointerRecipes are single-scalar if all their operands are. This should be effectively NFC currently, but it should re-enable cost checking for some more VPWidenMemoryRecipe after llvm#157387 as discovered by @john-brawn-arm.
|
@llvm/pr-subscribers-llvm-transforms Author: Florian Hahn (fhahn) ChangesVPVector(End)PointerRecipes are single-scalar if all their operands are. This should be effectively NFC currently, but it should re-enable cost checking for some more VPWidenMemoryRecipe after Full diff: https://github.com/llvm/llvm-project/pull/169249.diff 1 Files Affected:
diff --git a/llvm/lib/Transforms/Vectorize/VPlanUtils.cpp b/llvm/lib/Transforms/Vectorize/VPlanUtils.cpp
index 939216fe162a4..334ad973c5428 100644
--- a/llvm/lib/Transforms/Vectorize/VPlanUtils.cpp
+++ b/llvm/lib/Transforms/Vectorize/VPlanUtils.cpp
@@ -185,7 +185,8 @@ bool vputils::isSingleScalar(const VPValue *VPV) {
all_of(Rep->operands(), isSingleScalar));
}
if (isa<VPWidenGEPRecipe, VPDerivedIVRecipe, VPBlendRecipe,
- VPWidenSelectRecipe>(VPV))
+ VPWidenSelectRecipe, VPVectorPointerRecipe, VPVectorEndPointerRecipe>(
+ VPV))
return all_of(VPV->getDefiningRecipe()->operands(), isSingleScalar);
if (auto *WidenR = dyn_cast<VPWidenRecipe>(VPV)) {
return preservesUniformity(WidenR->getOpcode()) &&
|
|
@llvm/pr-subscribers-vectorizers Author: Florian Hahn (fhahn) ChangesVPVector(End)PointerRecipes are single-scalar if all their operands are. This should be effectively NFC currently, but it should re-enable cost checking for some more VPWidenMemoryRecipe after Full diff: https://github.com/llvm/llvm-project/pull/169249.diff 1 Files Affected:
diff --git a/llvm/lib/Transforms/Vectorize/VPlanUtils.cpp b/llvm/lib/Transforms/Vectorize/VPlanUtils.cpp
index 939216fe162a4..334ad973c5428 100644
--- a/llvm/lib/Transforms/Vectorize/VPlanUtils.cpp
+++ b/llvm/lib/Transforms/Vectorize/VPlanUtils.cpp
@@ -185,7 +185,8 @@ bool vputils::isSingleScalar(const VPValue *VPV) {
all_of(Rep->operands(), isSingleScalar));
}
if (isa<VPWidenGEPRecipe, VPDerivedIVRecipe, VPBlendRecipe,
- VPWidenSelectRecipe>(VPV))
+ VPWidenSelectRecipe, VPVectorPointerRecipe, VPVectorEndPointerRecipe>(
+ VPV))
return all_of(VPV->getDefiningRecipe()->operands(), isSingleScalar);
if (auto *WidenR = dyn_cast<VPWidenRecipe>(VPV)) {
return preservesUniformity(WidenR->getOpcode()) &&
|
Mel-Chen
left a comment
Mel-Chen
left a comment
There was a problem hiding this comment.
Could we directly return true, like VPReductionRecipe?
Wrong person mentioned? Should be @ElvisWang123? |
fhahn
left a comment
fhahn
left a comment
There was a problem hiding this comment.
after
Could we directly return true, like VPReductionRecipe?
Yep that works, updated, thanks
#157387 as discovered by @john-brawn-arm.
Wrong person mentioned? Should be @ElvisWang123?
The mention should be correct, @ElvisWang123 landed #157387, but @john-brawn-arm discovered the issue. I'll strip to the username mentions from the commit message, to avoid excessive Github notifications
5 participants
VPVector(End)PointerRecipes are single-scalar if all their operands are. This should be effectively NFC currently, but it should re-enable cost checking for some more VPWidenMemoryRecipe after
#157387 as discovered by @john-brawn-arm.